xREL.v3

Update v2.025:
Fix a potential bug with macrophage notifications after the player is dead
Thanks to Ovalcircle for reporting
Fixed a bug in the most recent two versions of the game where the various zombie factions and the outguard faction were not seeding UNLESS you happened to go into the lobby and hit Set to Defaults and then start the game. It's possible that quick starts were working properly, but not definite.
This won't affect existing savegames regarding outguard being summonable, but will affect any new ones created. For zombies, it will fix any problematic existing saves.
Thanks to Valkyr, Strategic Sage, Lord Of Nothing, DEMOCRACY_DEMOCRACY, Scout1Treia, and Poppy for reporting.
Fixed a bug where certain savegames could have not all the expansions in use actually noted as in use. This was going to be a problem for multiplayer, but we will probably have some further changes to make to that in the future.
In the short term, this could also cause some problems with detecting if relic trains were supposed to be enabled if you used certain quick starts or older savegames.
Thanks to Lord Of Nothing for reporting.
Somehow or other, Ovalcircle managed to get the game to remember his last settings as being those from the test chamber. That shouldn't have been possible, and we can't replicate it, but we've put in extra fixes to hopefully keep it from happening to anyone again.
Thanks to Ovalcircle for reporting.
Put in a fix that makes it so that if there are more factions than planet factions, it won't give an index out of range exception.
Put back in some code that will now add AI Reserves (and the zombies and outguard) to existing savegames that don't have them.
It won't actually seed any outguard beacons if those are missing, but it will make all the various sorts of zombies function properly if they were missing, which is a pretty big deal.
Previously we had taken this out, and only had it run when loading as a template of some fashion or from the lobby, because it caused a mismatch in factions and planet factions.
Put in some code that automatically fixes any missing planet factions for any galaxy-wide factions that are missing in a savegame that is loaded or other things that are created.
This fixes some serious issues in the test chamber, for one, but also makes it so that the other fixes above don't break the world.
Put in some more defensive code for a rare threading race condition exception that could happen in TryUpdatingTargetPoint of ShotVisualizer.
Thanks to Endovior for reporting.
Improved the wording in the quick start menu to say "no scenario selected" and similar, instead of "no save selected," so it's more clear what to do if you are having an error.
Thanks to UFO for reporting the confusion.
Fixed an issue in the quick start window and in the load savegame window where your old settings would be kept, but invisibly, when you exited the screen but went back in. You'd still have a scenario/save selected, but not visible.
Thanks to UFO for reporting.
Put in a fix that ignores an exception in GenerateCaret() for text mesh pro when we disabled a canvas. This has only been popping up recently for whatever reason, but should now just ignore the problem and keep moving when the canvas is next showed.
Thanks to Endovior and Badger for reporting.
Fixed an issue where, inexplicably, if we had a primary key for ships or shots that was more than 20 million it would start just giving them all the same primarykeyid which would then lead to all manner of problems.
This is not new, but it's only being encountered now, which is probably due to some particular factions in the specific savegame setup which cause a high ship PKID turnover. It still took 13 hours for this to come about.
The new cap is now properly a bit over 2 billion, which is 100x as high (and nearing the limit of 32bit integers). In the same sort of extreme scenario, with the same amount of churn, we can then assume it would take 1300 hours in one campaign to hit that new limit, so that's... certainly okay.
Huge thanks to choam and DarkWing for reporting and providing a save where we could reproduce this.
Because of the prior bug, when a savegame is loaded that has an entity with id 20000001, it now reassigns it on load. This will definitely cause some problems in those saves, but definitely fewer problems than them all sharing a primary key ID.
The PKIDs are supposed to be unique, but in the case of one particular savegame we had 9895 ships with all the ID 20000001, which meant all sorts of problems like ships not being selectable, not able to decollide, not able to get movement orders in general, and not able to get orders from the player or other factions. Instead, they could kind of sit in place and autotarget and that was it.
Reassigning PKIDs is itself one of those "never do this" things, so probably any save affected by this (very few, if any beyond the single one we have on hand) may find some inexplicable bugs like fire teams missing entries or pointing to the wrong thing, etc. Things seem to load and run fine, but if there are boogeymen in a save of this sort then you know it's probably related to this.
Huge thanks to choam and DarkWing for reporting and providing a save where we could reproduce this.

Update v2.024:
Fixed a complicated bug where the game was not properly able to detect when an input field lost focus by virtue of its whole ui canvas (window) being disabled. This led to large parts of the ui being disabled at times after showing an input field in the prior version of the game.
Two logic inversions in semi-related code also made that even worse, although one of them made it "better" enough that the ui worked at all. Nonetheless, this was a fix that needed to happen quickly.
Thanks to Valkyr for reporting.
Fixed a rare bug that could happen in fire teams updating and getting an index out of range exception at debug code 3100.

Update v2.023:
Allow non-scourge factions that use fireteams to stack when/where appropriate
Thanks to Swizzlewizzle for the bug report and save.
Fixed several nullref bugs relating to regenerator golems.
Thanks to Badger for reporting.
Added in new targeting logic for melee units that should allow them to better attack moving targets.
If issues crop up, or you prefer the old style, this can be enabled and disabled under the Units tab in Galaxy Settings.
UI / Chat Improvements
The hotkey for opening the chat window is now Return/Enter rather than C. This actually lets you do C-clicking still and C-hovering, etc, which has been impossible since adding the chat.
Thanks to UFO and Strategic Sage for reporting.
All of the various modifier keys for doing things like hiding tooltips no longer function while you are entering text into a textbox.
Simply having the chat window open no longer causes all other input to be blocked. Now you actually have to have the cursor in the chat textbox for that to be the case.
Hitting the escape key while you are in the chat window now properly closes that window, even if you are in text entry at the moment.
Hitting the escape key to close whatever window or popup no longer comes with a risk of opening the in-game escape/system menu. That has been annoying for a long time.
Thanks to a variety of people for reporting over the last few years.
When you first go into that chat window, or the modal textbox window, it now focuses the textbox there for immediate typing.
Additionally, after you send a chat message it immediately re-focuses the chat textbox.
The chat log now actually uses gametime timestamps, rather than "how many gametime seconds ago was it" to show things. This is a lot easier to read, since every second every line isn't changing width because of all the lines changing numbers every second.

Update v2.021:
Fix to a deserialization error with AI Reserves in the prior build which was affecting quick starts but not existing savegames. Sorry about that!

Update v2.019:
When the AI Reserves decide to attack, they now give you a Notification saying "AI Reserves arriving in X seconds" instead of just appearing instantly. This gives you the chance to scrap units, retreat, snipe the command station, etc...
Thanks to a number of people for requesting including Iocaine, swizzlewizzle, Lord of Nothing and his Inimitable Puffinness
Fix a null reference exception in in the Spire Debris notification; could only be hit if you were hovering the notification when the debris vanished
Thanks to Endovior for reporting
Alarm Posts now also free ships in Guard Posts
Thanks to GreatYng for reporting
Tidied up some names.
Extragalactic Thunderbird is now Extragalactic War Thunderchild.
Extragalactic Chimera is now Extragalactic War Chimera.
Extragalactic AI Hunter / Seeker is now Extragalactic War Hunter / Seeker.
Extragalactic AI Hunter / Annihilator is now Extragalactic War Hunter / Annihilator.
Extragalactic Jackalope is now Extragalactic War Jackalope.
Extragalactic Mothership is now Extragalactic War Mothership.
Extragalactic Planet Cracker is now Extragalactic War Planetcracker.
Thanks to Fluffiest for noting some of the inconsistencies.
For at least a month or so now, ever since we switched in the linked lists for storing entity lists instead of List<> and ArcenMob<>, and possibly slightly before that, if you were to do a swap between ship lines on a planet with a regenerator golem on it, you'd get a crash to desktop and a ton of extra ships in general.
In general, for some time now it has been allowing for various things to happen when you self-kill units (by scrapping or otherwise) that should not have been happening. This includes things like zombification copies being made, entities spawning on death in terms of things like hydra heads out of hydras, dying to remains, and regenerator golems spawning replacement ships. In this particular instance it could cause an infinite loop, but it was problematic in general.
There are still various other things that DO need to happen on-death even for scrapped units, like various loss conditions, AIP gains, and so on. And in the past, prior to us making some changes here that have led to this crash, we weren't running those things, which is problematic.
The game now does a much better job of telling all the sub-factions and so on what is happening and letting it react properly in the event of death from self-damage. So that solves the most recent problems, but keeps the longer-term benefits we've had for a while now.
Thanks to Bob for reporting.
Tweaked a couple of things in the "regenerator golem" code so that they should take the proper amount of damage now, rather than too much or too little. They also shouldn't be able to kill themselves anymore by taking too much damage.
Additionally, crippled regenerators stop helping at all.
Regenerators can't regenerate one another anymore (the AI could have multiple of them regenerating one another).
Thanks to Puffin for reporting.
The game now has 3 Pathing Modes to let ships figure out which planets to move through. Shortest (always use shortest path), Safest (always take the safest path) and Default (take the safest path unless it's significantly longer than the shortest path, in which case use the shortest path).
By default all player commands use the Default mode, but the player can hold a modifier key for the Safest or the Shortest path
Note to modders: FindPath() calls now take an extra argument.
Resolves pathing problems reported by a number of people, including UFO and Sigma7